This repository has been archived by the owner on Nov 7, 2024. It is now read-only.
Rename Volume => BindMountVolume #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be more explicit about the sort of volumes we are dealing with and clear the way for supporting other volume types in the future.
|
Related to #270 |
|
Technically a breaking change, though it doesn't break my use case (I just use |
|
@zachmullen It is, but as we haven't reached 1.0 I figure it was worth doing now. The eventual API would probably have a Volume base class with sub classes of BindMountVolume and ManagedVolume or something similar. |
|
Ok, thanks. |
zachmullen
approved these changes
Feb 1, 2018
There was a problem hiding this comment.
I approve, but @kotfic 's review should be the authoritative one.
kotfic
approved these changes
Feb 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be more explicit about the sort of volumes we are dealing with and clear the way for supporting other volume types in the future.